Talk:Thick Fat (Ability): Difference between revisions
(→About the Effect section and its accuracy ~~~~: new section) |
|||
| Line 7: | Line 7: | ||
Wait, I missed the "half"... Never mind.--[[User:Mackinz|Mackinz of SoulSilver]] ([[User talk:Mackinz|talk]]) 01:54, 22 March 2013 (UTC) | Wait, I missed the "half"... Never mind.--[[User:Mackinz|Mackinz of SoulSilver]] ([[User talk:Mackinz|talk]]) 01:54, 22 March 2013 (UTC) | ||
== About the Effect section and its accuracy [[User:Lunos|Lunos]] ([[User talk:Lunos|talk]]) 01:11, 27 February 2020 (UTC) == | |||
The Effect section for this ability should be separated as Gen. 3 and Gen. 4 onward, in my opinion. | |||
It's inaccurate to say that the ability reduced the Attacker's Attack stat in all the games that it's featured in without separating the effect in generations, because in the Gen. 3 Pokémon Games it reduces the attacker's Special Attack stat specifically, regardless of the P/S Split or lack thereof. | |||
https://github.com/pret/pokeruby/blob/6cf22f72d6c00406db59a7516c9708dccd820558/src/calculate_base_damage.c#L180 | |||
https://github.com/pret/pokefirered/blob/43f66fce5574592ac1c37b9452fe858e482156bb/src/pokemon.c#L2444 | |||
https://github.com/pret/pokeemerald/blob/172cb7bae96822dd9281b3b94ad738c3ce6e0161/src/pokemon.c#L3171 | |||
For insight, the lines of code I just linked come from the decompilation projects of the GBA Pokémon Games. An effort started by a group named "pret" who are aiming to recreate the matching source code of the GBA Pokémon Games ''(matching as in the same code that Game Freak wrote)''. | |||
This is achieved by dumping the game's code in ASM, rewriting those functions to C and then passing them through the same open source compiler that Game Freak used back in the day, in order to make sure that the code written in C matches theirs. | |||
I'm not sure if this would be an accepted change, which is the reason why I'm submitting this talk page to discuss it. I didn't want to take unnecessary liberties. | |||
Revision as of 01:11, 27 February 2020
Categories aren't showing for me at the bottom of the page. I tried to edit the page so they'd appear but I can't seem to. Kookamooka 15:25, 19 May 2012 (UTC)
How much does Thick Fat reduce damage?
I find it weird that Bulbapedia does not have this information yet. The ability has been out for over ten years now...--Mackinz of SoulSilver (talk) 01:39, 22 March 2013 (UTC)
Wait, I missed the "half"... Never mind.--Mackinz of SoulSilver (talk) 01:54, 22 March 2013 (UTC)
About the Effect section and its accuracy Lunos (talk) 01:11, 27 February 2020 (UTC)
The Effect section for this ability should be separated as Gen. 3 and Gen. 4 onward, in my opinion. It's inaccurate to say that the ability reduced the Attacker's Attack stat in all the games that it's featured in without separating the effect in generations, because in the Gen. 3 Pokémon Games it reduces the attacker's Special Attack stat specifically, regardless of the P/S Split or lack thereof.
For insight, the lines of code I just linked come from the decompilation projects of the GBA Pokémon Games. An effort started by a group named "pret" who are aiming to recreate the matching source code of the GBA Pokémon Games (matching as in the same code that Game Freak wrote). This is achieved by dumping the game's code in ASM, rewriting those functions to C and then passing them through the same open source compiler that Game Freak used back in the day, in order to make sure that the code written in C matches theirs.
I'm not sure if this would be an accepted change, which is the reason why I'm submitting this talk page to discuss it. I didn't want to take unnecessary liberties.
